Make it possible to override proxy settings #822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanux
approved these changes
Jun 25, 2024
|
Do we need to update the tests as well? |
|
Existing tests did not fail, but it's worth adding the ones that will check this new behavior |
yzha645
reviewed
Jun 25, 2024
| @@ -34,8 +34,8 @@ data: | |||
| acceptCount="{{ .Values.bamboo.tomcatConfig.acceptCount | default "10" }}" | |||
| secure="{{ default (ternary "true" "false" .Values.ingress.https) .Values.bamboo.tomcatConfig.secure }}" | |||
There was a problem hiding this comment.
Shall these be vice versa as well?
There was a problem hiding this comment.
Logically yes, but I doubt there's a valid use case to justify setting http in ingress and http in tomcatconfig.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #821
Fallback to ingress settings if no config is provided for proxies.