Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix default for acceptCount #832

Merged
merged 2 commits into from
Jul 15, 2024
Merged

Fix default for acceptCount #832

merged 2 commits into from
Jul 15, 2024

Conversation

bianchi2
Copy link
Collaborator

It should be 100 not 10.

@bianchi2 bianchi2 requested review from nanux and yzha645 as code owners July 15, 2024 00:55
@yzha645
Copy link
Collaborator

yzha645 commented Jul 15, 2024

Shall we update it in corresponding Docker repo as well?

@yzha645
Copy link
Collaborator

yzha645 commented Jul 15, 2024

And there are incorrect defaults in configmap-server-config.yamls as well.

@bianchi2
Copy link
Collaborator Author

Updated defaults in templates (even though they won't be applied unless it's set to null in values)

Shall we update it in corresponding Docker repo as well?
We will, yes. Jira and Confluence have 10 as the default. When not specified it's 100 by default according to Tomcat docs.

@bianchi2 bianchi2 merged commit b052095 into main Jul 15, 2024
3 checks passed
@bianchi2 bianchi2 deleted the BAM-25831-fix-max-acceptcount branch July 15, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yzha645 yzha645 yzha645 approved these changes

@nanux nanux Awaiting requested review from nanux nanux is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bianchi2 @yzha645