Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add s3 backups to Helm values #907

Merged
merged 3 commits into from
Nov 14, 2024
Merged

Add s3 backups to Helm values #907

merged 3 commits into from
Nov 14, 2024

Conversation

bianchi2
Copy link
Collaborator

@bianchi2 bianchi2 commented Nov 10, 2024

Now that Jira filestore-config.xml Jinja template supports S3 config for backups, let's add it to existing Helm values stanza.

Also, improving unit tests a little bit to loop through all 3: avatars, attachments and backups.

Checklist

  • I have added unit tests
  • I have applied the change to all applicable products
  • The E2E test has passed (use e2e label)

@bianchi2 bianchi2 added e2e and removed e2e labels Nov 11, 2024
Copy link
Member

@nanux nanux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thanks @bianchi2 🚀

@bianchi2 bianchi2 merged commit f86fb92 into main Nov 14, 2024
14 checks passed
@bianchi2 bianchi2 deleted the jira-s3-backups branch November 14, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants