Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sfarsaci/update alpine #492

Merged
merged 6 commits into from
Apr 5, 2022
Merged

Sfarsaci/update alpine #492

merged 6 commits into from
Apr 5, 2022

Conversation

sfarsaci
Copy link

@sfarsaci sfarsaci commented Apr 5, 2022

No description provided.

@sfarsaci sfarsaci force-pushed the sfarsaci/update-alpine branch from 5c20ee6 to 0a0795b Compare April 5, 2022 06:31
@sfarsaci sfarsaci requested a review from MovieStoreGuy April 5, 2022 06:31
version: v1.45.2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does golangci-lint as an action mean we don't need to run golangci-lint in the build? (#481 relates)

I'm about to throw in a PR to disable bench-race and golangci-lint for arm64, but if I can remove golangci-lint from both, that's even better.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it means it can be canned.

@MovieStoreGuy MovieStoreGuy merged commit a4682a9 into master Apr 5, 2022
@tiedotguy tiedotguy deleted the sfarsaci/update-alpine branch August 16, 2022 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants