Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#966 nextjs example template #1009

Open
wants to merge 29 commits into
base: develop
Choose a base branch
from
Open

#966 nextjs example template #1009

wants to merge 29 commits into from

Conversation

joepio
Copy link
Member

@joepio joepio commented Nov 4, 2024 •
edited by RoelLeijser
Loading

Related Issues

Todo

  • Feature parity with Sveltekit template
    • Render a dynamic page
    • Menu items
    • Search bar
    • Search results
  • Update Generator to support template
  • Readme for local dev
  • Update docs
  • Give feedback in this issue, e.g. about reusable component needs
  • Netlify deploy in readme
  • Try a netlify deploy, see if it all works (Statically / SSR)
  • E2E tests

Checklist

  • Add changelog entry linking to issue, describe API changes
  • Add or update tests if needed
  • Update docs if needed

@joepio joepio requested a review from Polleps November 4, 2024 10:31
@RoelLeijser RoelLeijser force-pushed the #966-nextjs-example-template branch from a94e443 to cc75ad6 Compare November 6, 2024 12:20
Polleps
Polleps requested changes Nov 11, 2024
View reviewed changes
browser/create-template/templates/nextjs-site/next.config.mjs Outdated Show resolved Hide resolved
browser/create-template/templates/nextjs-site/src/app/[...slug]/page.tsx Outdated Show resolved Hide resolved
browser/create-template/templates/nextjs-site/src/app/globals.css Outdated Show resolved Hide resolved
browser/create-template/templates/nextjs-site/src/app/layout.tsx Show resolved Hide resolved
browser/create-template/templates/nextjs-site/src/components/Layout/HStack.module.css Outdated Show resolved Hide resolved
browser/create-template/templates/nextjs-site/src/views/ListItem/BlogListItem.tsx Outdated Show resolved Hide resolved
browser/create-template/templates/nextjs-site/src/views/MenuItem/MenuItem.tsx Outdated Show resolved Hide resolved
browser/create-template/templates/nextjs-site/src/views/MenuItem/MenuItem.tsx Outdated Show resolved Hide resolved
browser/create-template/templates/nextjs-site/src/views/MenuItem/MenuItem.tsx Outdated Show resolved Hide resolved
browser/create-template/templates/nextjs-site/src/views/MenuItem/MenuItem.tsx Outdated Show resolved Hide resolved
@RoelLeijser RoelLeijser force-pushed the #966-nextjs-example-template branch from 82b887c to 6d00312 Compare November 14, 2024 15:44
@RoelLeijser RoelLeijser force-pushed the #966-nextjs-example-template branch 2 times, most recently from 1a6ff6f to 53eed8f Compare December 10, 2024 13:59
@joepio
Copy link
Member Author

joepio commented Dec 16, 2024

Netlify and Vercel now working, Netlify had some issues (CSS not working)

@joepio
Copy link
Member Author

joepio commented Jan 27, 2025

We discussed E2E tests.

The tests should probably be run in Playwright.

  • Setup a Drive, apply Website template, copy the Subject of the Drive
  • Run create template CLI command (use child_process)
  • Run generate_ontologies
  • Run pnpm run dev or similar
  • Load the website
  • Check some content
  • Check if there is no "loading"
  • Check search
  • (bonus points) make an edit, like a new page

@RoelLeijser
Add CurrentSubjectContext with errors
a4474c9
@RoelLeijser
Start migrating to server components (breaking)
efced8b
@RoelLeijser
Upgrade next to v15
02d59f4
@RoelLeijser
Update template to server components
90b1bb8
@RoelLeijser
Migrate to ESLint v9
e4ab726
@RoelLeijser
Modified the Search functionality to server components with streaming
f846e26
@RoelLeijser
Refactor for client side
8382f04
@RoelLeijser
Implement feedback
49cceba
@RoelLeijser
Update README.md
fdcf060
@RoelLeijser
Move store
2e8288f
@RoelLeijser
Enhance Next.js template
7706c39
@RoelLeijser
Implement feedback and fixes
17e5a1e
@RoelLeijser
Add dynamic file extension handling in ontology index generation when…
adf745b 
… using bundler
@RoelLeijser
Add cli support for Next.js template
8d7c922
@RoelLeijser
Small fixes
f7f36f3
@RoelLeijser
Refactor CSS styles and update navbar
a9ad3ac
@RoelLeijser
Refactor MenuItem components
58c0b9a
@RoelLeijser
Add deployment instructions for Netlify in README
09928e3
@RoelLeijser
Refactor layout and context management
d7bc571
@RoelLeijser
Refactor MenuItem components and update dependencies
09f9f59
@RoelLeijser
Add deployment instructions for Netlify and Vercel to README, remove …
c3837de 
…old DEPLOYING.md
@RoelLeijser
Add nextjs-site template to documentation
0c7df48
@RoelLeijser
Add e2e next template tests
d7640dc
@RoelLeijser
Add SvelteKit to templte e2e test
d24da3b
@RoelLeijser
Update e2e tests with fix for occupied ports
e3b69fc
@RoelLeijser RoelLeijser force-pushed the #966-nextjs-example-template branch from b5779ff to e3b69fc Compare January 29, 2025 15:14
@RoelLeijser RoelLeijser marked this pull request as ready for review January 29, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RoelLeijser RoelLeijser RoelLeijser left review comments

@Polleps Polleps Polleps requested changes

Assignees

@RoelLeijser RoelLeijser

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add NextJS example template
3 participants
@joepio @Polleps @RoelLeijser