Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: AtClientImpl for GET and PUT byte[] Method #110

Closed
wants to merge 1 commit into from

Conversation

JayUpadhyay-8
Copy link
Contributor

@JayUpadhyay-8 JayUpadhyay-8 commented Mar 31, 2023

closes #38

@JayUpadhyay-8 JayUpadhyay-8 marked this pull request as ready for review March 31, 2023 16:40
@JayUpadhyay-8 JayUpadhyay-8 marked this pull request as draft March 31, 2023 16:42
Copy link
Member

@JeremyTubongbanua JeremyTubongbanua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great so far!

Could you provide some code and output to show it is working? Just send the code here in the conversation and some screenshots of the output.

Thanks a ton!

@JeremyTubongbanua JeremyTubongbanua changed the title Updated AtClientImpl for GET and PUT byte[] Method feat: AtClientImpl for GET and PUT byte[] Method Apr 3, 2023
@JayUpadhyay-8
Copy link
Contributor Author

Hi Jeremy,

I have written a TempTestDriver class to test this code. I am providing its code and screenshot for you to better understand its working.

`
public class TemporaryTest {
public static void main(String[] args) throws Exception {
AtSign atSign = new AtSign("@16ourfeminist");
AtClient atClient = AtClient.withRemoteSecondary("root.atsign.org:64", atSign, true);

    PublicKey pk = new KeyBuilders.PublicKeyBuilder(atSign).key("test").build();

    byte[] value = "testToken".getBytes();

    String response = atClient.put(pk, value).get();

    System.out.println("response here -- " + response);

    byte[] getPublicValue = atClient.getBinary(pk).get();

    String str = new String(getPublicValue);

    System.out.println("get public key -- " + str + " get public value -- " + getPublicValue);

}

}
`
TempTest Output

@JeremyTubongbanua
Copy link
Member

Closing, please make a PR to this branch

@JeremyTubongbanua
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement _getBinary(AtKey) and _put(AtKey, byte[])
2 participants