Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat:replace md5 checksum #511

Merged
merged 4 commits into from
Feb 6, 2024
Merged

feat:replace md5 checksum #511

merged 4 commits into from
Feb 6, 2024

Conversation

murali-shris
Copy link
Member

@murali-shris murali-shris commented Feb 3, 2024 •
edited
Loading

- What I did

  • at_commons changes to replace md5 with sha256/512
    - How I did it
  • introduced new object PublicKeyHash which has the hash of public key and hashing algo used.
  • added custom object PublicKeyHash to at_key.dart
  • changes to toJson and toProtocolFragment methods in metadata
  • deprecated pubKeyCS in at_key.dart
  • added unit tests

- How to verify it

  • unit tests should pass

gkc
gkc reviewed Feb 3, 2024
View reviewed changes
packages/at_commons/lib/src/keystore/public_key_hash.dart Outdated
/// Represents hash of an atsign's public encryption key and the hashing algorithm used
class PublicKeyHash {
String? hash;
PublicKeyHashingAlgo? publicKeyHashingAlgo;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these nullable?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

field should not be nullable. I have removed nullable fields

@murali-shris murali-shris marked this pull request as ready for review February 5, 2024 16:22
@murali-shris murali-shris requested a review from gkc February 5, 2024 17:23
@gkc gkc merged commit 237f42f into trunk Feb 6, 2024
11 checks passed
@gkc gkc deleted the at_commons_replace_md5 branch February 6, 2024 11:29
@gkc
Copy link
Contributor

gkc commented Jul 25, 2024 •
edited
Loading

@murali-shris pubKeyCS is marked as deprecated but pubKeyHash is not being used in any other package that I can find. What's the plan here? I think to prevent confusion we need to remove the deprecation annotation until at_server and at_client_sdk fully support pubKeyHash. I'll make a PR to that effect. (PR here was merged a while back)

@gkc
Copy link
Contributor

gkc commented Oct 11, 2024

@murali-shris Please see above comment; can you create a ticket to uptake pubKeyHash in (a) atServer (b) at_client_sdk (c) at_c_sdk

@murali-shris murali-shris mentioned this pull request Oct 14, 2024
Closed
@murali-shris
Copy link
Member Author

@murali-shris Please see above comment; can you create a ticket to uptake pubKeyHash in (a) atServer (b) at_client_sdk (c) at_c_sdk
atsign-foundation/at_server#2121
atsign-foundation/at_client_sdk#1417
atsign-foundation/at_c#424

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkc gkc gkc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@murali-shris @gkc