-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added WebSocket support in AtLookup #709
Closed
Closed
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
b586311
changed version of websocket
purnimavenkatasubbu caa7591
websocket changes
purnimavenkatasubbu ffc02f5
Merge remote-tracking branch 'origin/trunk' into ws_version2
gkc 63fc299
fixed closing ws connection
purnimavenkatasubbu df4658d
changes
purnimavenkatasubbu ab88f5e
Merge branch 'trunk' of https://github.com/atsign-foundation/at_libra…
purnimavenkatasubbu d88a139
Merge branch 'trunk' of https://github.com/atsign-foundation/at_libra…
purnimavenkatasubbu 417234c
refactored code
purnimavenkatasubbu 0eca375
Merge branch 'trunk' of https://github.com/atsign-foundation/at_libra…
purnimavenkatasubbu b78716a
refactored code based on factories
purnimavenkatasubbu 3f453af
removed commented code
purnimavenkatasubbu 0452d85
Merge branch 'trunk' of https://github.com/atsign-foundation/at_libra…
purnimavenkatasubbu a72cf1a
addressed review comments
purnimavenkatasubbu a7c8e64
updated unit tests
purnimavenkatasubbu aee94bb
fixed failing test
purnimavenkatasubbu a67171b
fix: Updated mock references to prevent null pointer errors
sitaram-kalluri 49b840b
fix: Add unit test - A test to verify the connections are invalidated…
sitaram-kalluri 4f23462
fixed failing unit test
purnimavenkatasubbu 95fc90c
pubspec
purnimavenkatasubbu a635041
correct atsign and removed commented code
purnimavenkatasubbu 65f6141
removed useWebSocket flag and added unit tests
purnimavenkatasubbu 61e2913
renamed variables and minor changes
purnimavenkatasubbu b4eef12
addressed review comments
purnimavenkatasubbu ab72ec6
Merge branch 'trunk' of https://github.com/atsign-foundation/at_libra…
purnimavenkatasubbu be8058b
addressed review commits
purnimavenkatasubbu b32009b
removed commented code
purnimavenkatasubbu 9ea9415
review comments
purnimavenkatasubbu 5dc5a47
removed commented code
purnimavenkatasubbu 3e05187
addressed more review comments
purnimavenkatasubbu 8e5aaee
changing heirarchy and removeing outboundconnection
purnimavenkatasubbu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since we have modified SecondaryUrlFinder constructor and exported this class, the change should be treated as breaking and have a major release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated be8058b