Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Websocket uptake in at_lookup #732

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from

Conversation

purnimavenkatasubbu
Copy link
Member

- What I did
Implemented WebSocket support by introducing a new connection factory structure to support both SecureSocket and WebSocket connections. This update allows AtLookupImpl to dynamically choose between secure socket and WebSocket connections, enhancing flexibility and enabling WebSocket-based communication when required.

- How I did it

  • Created a new abstract factory class, AtLookupOutboundConnectionFactory, to standardize the creation of underlying connections, outbound connection wrappers, and message listeners for different connection types.
  • Developed AtLookupSecureSocketFactory and AtLookupWebSocketFactory to handle secure socket and WebSocket connections, respectively. Each factory is responsible for:
    • Establishing the underlying connection (either SecureSocket or WebSocket).
    • Wrapping the connection into an outbound connection instance (OutboundConnectionImpl or OutboundWebsocketConnectionImpl).

- How to verify it

  • Existing tests for SecureSocket connections should continue working as expected.
  • Added functional tests by passing the AtLookupWebSocketFactory should pass

- Description for the changelog

add WebSocket support in AtLookupImpl

Copy link
Contributor

@gkc gkc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@purnimavenkatasubbu
Copy link
Member Author

Functional tests are failing https://github.com/atsign-foundation/at_libraries/actions/runs/12242458255/job/34149828665?pr=732

Yes Gary, Websocket tests will pass only with the websocket server branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants