Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use random IV in AtClient put/get methods #64

Draft
wants to merge 10 commits into
base: trunk
Choose a base branch
from

Conversation

realvarx
Copy link
Contributor

@realvarx realvarx commented Oct 9, 2023

Put methods were not creating random IVs for AES encryption and Get methods were not using metadata IVs for decryption.

- What I did
Create random IVs using EncryptionUtil.generate_iv_nonce() and correct the way they are stored in the secondary server.

- How to verify it
Check automatic tests and look changes in the code.

- Description for the changelog
fix: Use random IV in AtClient put/get methods

@realvarx realvarx requested review from cpswan and Xlin123 October 9, 2023 12:23
@realvarx realvarx self-assigned this Oct 9, 2023
@realvarx realvarx removed request for cpswan and Xlin123 October 9, 2023 12:28
@realvarx realvarx marked this pull request as draft October 9, 2023 12:29
@realvarx
Copy link
Contributor Author

realvarx commented Oct 9, 2023

Still have to make changes to some tests, as they are not taking in account IV generation.

Should create a set_iv_nonce method for SharedKey and SelfKey classes, so this parameter can be modified before actually using put/get methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant