Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: at_persistence _impl changes for replacing md5 #1775

Closed
wants to merge 4 commits into from

Conversation

murali-shris
Copy link
Member

@murali-shris murali-shris commented Feb 3, 2024

- What I did

  • changes in persistence for replacing md5 with sha256/512
    - How I did it
  • added a custom object PublicKeyHash in hive meta data and corresponding changes in at_meta_data.dart
  • introduced HiveAdapter for PublicKeyHash and registered the adapter on init
  • added unit test in at_metadata_test.dart
    - How to verify it
  • unit tests should pass

#TODO replace dependency overrides in pubspec with published version

@@ -115,6 +124,9 @@ class AtMetaData extends HiveObject {
..dataSignature = metadata.dataSignature
..sharedKeyEnc = metadata.sharedKeyEnc
..pubKeyCS = metadata.pubKeyCS
..publicKeyHash = (PublicKeyHash()
..hash = metadata.pubKeyHash!.hash
..hashingAlgo = metadata.pubKeyHash!.publicKeyHashingAlgo!.name)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to handle nulls here also

@@ -1,3 +1,4 @@
import 'package:at_commons/at_commons.dart' as at_commons;
import 'package:at_commons/at_commons.dart';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why imported twice?

@murali-shris murali-shris changed the title feat: at_persistence changes for replacing md5 feat: at_persistence _impl changes for replacing md5 Feb 13, 2024
@murali-shris
Copy link
Member Author

Changes implemented in #2160
Closing this PR

@murali-shris murali-shris deleted the at_persistence_replace_md5 branch December 24, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants