Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Intermittent failure in create_update_key_test.dart #2134

Merged

Conversation

sitaram-kalluri
Copy link
Member

- What I did

  • The failure is because of the timing issue between the key creation date time and date time in the metadata.
var keyCreationDateTime = DateTime.now().toUtc();
expect(DateTime.parse(atData['metaData']['createdAt']).millisecondsSinceEpoch > keyCreationDateTime.millisecondsSinceEpoch, true);

Since, the check contains only greater than, if the date time in keyCreationDateTime and in metadata happens at the same time, then the test fails. To fix the issue, modified the condition as greater than or equal to:

expect(DateTime.parse(atData['metaData']['createdAt']).millisecondsSinceEpoch >= keyCreationDateTime.millisecondsSinceEpoch, true);

@sitaram-kalluri sitaram-kalluri linked an issue Oct 17, 2024 that may be closed by this pull request
@sitaram-kalluri sitaram-kalluri merged commit aedef47 into trunk Oct 17, 2024
26 checks passed
@sitaram-kalluri sitaram-kalluri deleted the 2132-functional-tests-failing-in-stable-and-beta branch October 17, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Functional tests failing (in stable and beta)
2 participants