chore(deps): Update and fix all dependencies #741
Conversation
XavierChanth
changed the title
|
I'm going to leave comments on each pubspec.yaml with which dependencies had major version changes, and then we can determine whether we should consider those packages as breaking. |
| } | ||
| }); | ||
| if (context.mounted) { | ||
| var size = MediaQuery.of(context).size; |
There was a problem hiding this comment.
Wrapped with a mounted check
| final file = XFile(tempFilePath); | ||
| await file.saveTo(path ?? ''); | ||
| await file.saveTo(path.path); | ||
| if (context.mounted) { |
There was a problem hiding this comment.
getSavePath was removed in 1.0.0 of path_selector, so I replaced it with the getSaveLocation
| @@ -1,4 +1,5 @@ | |||
| name: at_widgets | |||
|
|
|||
| packages: | |||
| - packages/** | |||
| - packages/* | |||
| - packages/*/*example | |||
There was a problem hiding this comment.
Explicitly identified the packages and example globs just in case there are further nested pubspec.yaml files which we might want to ignore in melos
|
|
||
| # desktop - dependencies | ||
| file_selector: '>=0.8.4+1 <2.0.0' | ||
| file_selector_macos: '>=0.8.2 <1.0.0' |
There was a problem hiding this comment.
file_selector '>=0.8.4+1 <2.0.0' -> ^1.0.1
| ); | ||
| atClientPreference = await futurePreference; | ||
| if (context.mounted) { | ||
| final result = await AtOnboarding.onboard( |
There was a problem hiding this comment.
Uptake of the new onboarding widget
| proj4dart: ^2.1.0 | ||
| meta: ^1.9.1 | ||
| geolocator: ^9.0.2 |
There was a problem hiding this comment.
geolocator ^9.0.2 -> ^10.0.1
| case AtOnboardingResultStatus.cancel: | ||
| break; | ||
| if (context.mounted) { | ||
| final result = await AtOnboarding.onboard( |
There was a problem hiding this comment.
Wrapped with a context.mounted check
| }); | ||
| onDidReceiveNotificationResponse: (NotificationResponse payload) { | ||
| onNotificationClick(payload); | ||
| }); | ||
| } |
There was a problem hiding this comment.
The _notificationsPlugin.initialize API changed, I'm not sure if this is correct, I will be investigating this one for breaking changes.
| } | ||
|
|
||
| initializePlatformSpecifics() { | ||
| var initializationSettingsAndroid = | ||
| AndroidInitializationSettings('notification_icon'); | ||
| var initializationSettingsIOS = IOSInitializationSettings( | ||
| var initializationSettingsIOS = | ||
| DarwinInitializationSettings( |
There was a problem hiding this comment.
IOSInitializationSettings is now DarwinInitializationSettings
| @@ -65,13 +66,13 @@ class NotificationService { | |||
| AndroidNotificationDetails( | |||
| 'CHANNEL_ID', | |||
| 'CHANNEL_NAME', | |||
| 'CHANNEL_DESCRIPTION', | |||
| channelDescription: 'CHANNEL_DESCRIPTION', | |||
There was a problem hiding this comment.
This changed from a positional argument to a named one
| sliding_up_panel: ^2.0.0+1 | ||
| geolocator: ^9.0.2 |
There was a problem hiding this comment.
geolocator ^9.0.2 -> ^10.0.1
... does events even use geolocator???
| @@ -69,7 +68,7 @@ void main() { | |||
|
|
|||
| test('AtSyncUIService sync', () { | |||
| AtSyncUIService().syncService = mockSyncService; | |||
| AtClientManager.getInstance().syncService = mockSyncService; | |||
| AtClientManager.getInstance().atClient.syncService = mockSyncService; | |||
There was a problem hiding this comment.
Updated to use the non-deprecated API
@XavierChanth IMO if any of the major dependency update causes change in our package api then we should be considering for a major version change else minor should be fine. |
|
Package versions to be published with this PR: at_backupkey_flutter: 4.0.11
at_chat_flutter: 3.0.10
at_contacts_flutter: 4.0.12
at_contacts_group_flutter: 4.0.14
at_events_flutter: 3.1.12
at_follows_flutter: 3.0.10
at_invitation_flutter: 2.0.1
at_location_flutter: 3.1.10
at_login_flutter: 0.0.2
at_notify_flutter: 1.0.8
at_onboarding_flutter: 6.1.4
at_sync_ui_flutter: 1.0.10
at_theme_flutter: 1.0.6 |
There was a problem hiding this comment.
Great work @XavierChanth
Mostly LGTM, but @sachins-geekyants is right about at_onboarding_flutter needing to be local
|
@sachins-geekyants @cpswan both have been fixed |
|
Please hold off on merging, until all publishing has been complete, just in case there are further changes that need to be added and reviewed |
|
Publishing list:
|
XavierChanth
dismissed stale reviews from sachins-geekyants and cpswan
via
294a0a2
- What I did
- How to verify it
- Description for the changelog
deps: Update and fix all dependencies