Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add Flutter beta channel to static analysis matrix #846

Merged
merged 2 commits into from
May 20, 2024

Conversation

cpswan
Copy link
Member

@cpswan cpswan commented May 20, 2024

Fixes #845

- What I did

Added another dimension to test matrix that uses beta channel in addition to stable.

- How I did it

Based on tests for at_server

- How to verify it

CI should now have double the runs.

- Description for the changelog

ci: Add Flutter beta channel to static analysis matrix

@cpswan cpswan requested review from gkc and sitaram-kalluri May 20, 2024 12:01
@cpswan cpswan self-assigned this May 20, 2024
@cpswan
Copy link
Member Author

cpswan commented May 20, 2024

@gkc what do you think of putting a conditional in place for the beta channel so that we don't suppress info output from flutter analyze? That way I think we'll be pushed to be more proactive in dealing with deprecation warnings before they become problematic?

@gkc
Copy link
Contributor

gkc commented May 20, 2024

@gkc what do you think of putting a conditional in place for the beta channel so that we don't suppress info output from flutter analyze? That way I think we'll be pushed to be more proactive in dealing with deprecation warnings before they become problematic?

That sounds like a very good idea

gkc
gkc previously approved these changes May 20, 2024
@cpswan
Copy link
Member Author

cpswan commented May 20, 2024

@gkc that change is in, so ready for another review.

Lots of work to be done in #847

@cpswan cpswan merged commit 4c63066 into trunk May 20, 2024
17 of 31 checks passed
@cpswan cpswan deleted the cpswan-beta-static-analysis branch May 20, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add beta channel to static analysis tests so that we get early warning of failures.
2 participants