Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace deprecated elements with equivalent up-to-date items #849

Merged
merged 5 commits into from
May 23, 2024

Conversation

srieteja
Copy link
Contributor

Closes #843

- What I did

  • Replaced deprecated elements in at_onboarding_flutter's example app with up-to-date design elements

- How I did it

  • BackgroundColor in MaterialApp() was previously deprecated and now removed. The latest version's equivalent of BackgroundColor is called 'surface' which is now used in the examples
  • Also Changed:
  1. color: Theme.of(context).backgroundColor -> color: Theme.of(context).canvasColor

  2. style: Theme.of(context).textTheme.bodyText1 -> style: Theme.of(context).textTheme.bodyMedium,

- How to verify it

  • Static analysis should pass. Also, requires manual testing to ensure design elements are not broken

- Description for the changelog

fix: replace deprecated elements with equivalent up-to-date items

@cpswan
Copy link
Member

cpswan commented May 23, 2024

@srieteja I've merged #850 as we don't need to have the beta tests passing (yet)

This one is also good to go once you've confirmed that the manual tests are OK.

@srieteja
Copy link
Contributor Author

@cpswan this one's build has been failing since last night. Currently trying to get a clean build.

@gkc
Copy link
Contributor

gkc commented May 23, 2024

@cpswan this one's build has been failing since last night. Currently trying to get a clean build.

@srieteja which build are you referring to? Only the checks on the beta channel are failing on this PR

@srieteja
Copy link
Contributor Author

@gkc I'm trying to build the code into an apk and run it in an emulator. To see the new changes are working just fine. This build has been failing for me.

@srieteja
Copy link
Contributor Author

@cpswan this one has passed manual testing too. Thanks @CurtlyCritchlow for the help.

@srieteja srieteja requested a review from cpswan May 23, 2024 13:09
Copy link
Contributor

@gkc gkc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gkc gkc merged commit 3afc6db into trunk May 23, 2024
20 of 31 checks passed
@gkc gkc deleted the fix_deprecations_srie branch May 23, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flutter analyze failing on at_onboarding_flutter due to deprecation
3 participants