-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Clear Up Info Messages for at_widget packages using flutter 3.23 beta channel #860
chore: Clear Up Info Messages for at_widget packages using flutter 3.23 beta channel #860
Conversation
…info message fixed.
… in at_events_flutter
…at_location_flutter.
… for at_notify_flutter
…n example app of at_notify_flutter.
…lved in at_sync_ui_flutter.
…tions info message in the example app of at_sync_ui_flutter
…fixed in at_sync_ui_flutter
…n example app of at_sync_ui_flutter
…n example app of at_theme_flutter
…backupkey_flutter
…contacts_group_flutter.
…_location_flutter.
@cpswan One of the check failed. This because |
…t defined on the stable channel.
Can we put an annotation in place to supress that info message, and an issue to remind us to make the change once it lands in stable. Breaking changes > Generic types in PopScope for reference. |
… • 'onPopInvoked' is deprecated and shouldn't be used. Use onPopInvokedWithResult instead.
…lyze-flutter-beta-323-edition
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may be premature, as the PR is still draft, but I'm happy for this to be merged, so long as your confident with tests.
The one thing I did notice, which can be changed now, or later, or maybe even left, is the example pubspecs still use a very old flutter_lints
@@ -41,7 +41,7 @@ dependencies: | |||
# activated in the `analysis_options.yaml` file located at the root of your | |||
# package. See that file for information about deactivating specific lint | |||
# rules and activating additional ones. | |||
flutter_lints: ^1.0.0 | |||
flutter_lints: ^2.0.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not 4.0.0 here?
@@ -42,6 +43,8 @@ dependencies: | |||
cupertino_icons: ^1.0.6 | |||
flutter: | |||
sdk: flutter | |||
flutter_dotenv: ^5.1.0 | |||
path_provider: ^2.1.3 | |||
|
|||
dev_dependencies: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very old flutter_lints here too.
path_provider: ^2.1.3 | ||
at_common_flutter: ^2.0.13 | ||
at_lookup: ^3.0.47 | ||
flutter_dotenv: ^5.1.0 | ||
|
||
dev_dependencies: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and here
@@ -37,6 +39,7 @@ dependencies: | |||
cupertino_icons: ^1.0.6 | |||
flutter: | |||
sdk: flutter | |||
path_provider: ^2.1.3 | |||
|
|||
dev_dependencies: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and here
# The following adds the Cupertino Icons font to your application. | ||
# Use with the CupertinoIcons class for iOS style icons. | ||
cupertino_icons: ^1.0.6 | ||
flutter: | ||
sdk: flutter | ||
flutter_colorpicker: ^1.1.0 | ||
path_provider: ^2.1.3 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and here
at_common_flutter: ^2.0.12 | ||
at_onboarding_flutter: ^6.1.7 | ||
at_theme_flutter: | ||
path: ../ | ||
cupertino_icons: ^1.0.6 | ||
flutter: | ||
sdk: flutter | ||
path_provider: ^2.1.3 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and here
@cpswan I'm about to inbox you about a strategy for publishing the new versions of our packages. I didn't update the dependencies as yet because in some cases it cause conflicts due to other at_widgets packages that are dependencies using older versions and not the newer versions. |
- What I did
closes #859
- How I did it
Run flutter analyze to see info message.
Make the changes to clear the info message
- How to verify it
Github static analyser should run successfully.
- Description for the changelog
Clear up info messages