Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Uptake at_client_mobile 3.2.18 #888

Conversation

sitaram-kalluri
Copy link
Member

- What I did

  • Uptake at_client_mobile 3.2.18 changes into at_onboarding_flutter.

- How I did it

  • Refactor "onboard" and "authenticate" methods to use "AtAuthService" instead of "AtClientService" which is introduced in at_client_mobile.
  • In onboarding_service.dart, mark "atClientServiceMap" as deprecated. This is used in the wavi mobile apps. Perhaps might have its usage in other mobile apps also. Hence marking as deprecated and adding instance of "AtClientService" as value to prevent breaking change.
  • Added "enroll" method to submit a new enrollment request

- How to verify it

  • Manually tested with at_onboarding_flutter example and wavi mobile app.

Copy link
Contributor

@CurtlyCritchlow CurtlyCritchlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and the example app works. Unable to verify with wavi.

@CurtlyCritchlow CurtlyCritchlow merged commit 3450442 into 865-publish-new-versions-of-the-at_widget-packages Aug 12, 2024
3 checks passed
@sitaram-kalluri sitaram-kalluri deleted the sr_onboarding_changes branch August 13, 2024 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants