fix: #220 UI Redesign - Mobile - Terms & Condition page #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanmoy27112000
changed the title
|
@ksanty please review this |
|
@tanmoy27112000 Please could you make it so that the widget appears when someone clicks Terms & Conditions in the menu? |
|
@tinashe404 sure |
|
@tinashe404 you can click on the terms and condition button to see the widget |
|
@tanmoy27112000 Clicking terms and conditions opens up a page with the terms and conditions button but the button isn't doing anything. |
|
@tinashe404 added onTap method |
|
@tinashe404 the Hacktoberfest website is showing the repo as non participating. since Hacktoberfest tag is not added. can that be done |
|
I've added the hacktoberfest topic (and some others) to this repo |
|
@tinashe404 please check this PR . Conflicts resolved |
|
on tap method takes to the terms web screen @tinashe404 please check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
If this is a bug fix, I Closed #220 . Added the terms and condition button for the settings page
- How I did it
I created a separate file for setting page button and made it such that all button can use the same widget.
- How to verify it
Just add the following code
SettingPageButton( iconPath: ImageConstants.termsAndConditionsIcon, title: "Terms & Conditions", )to get the widget
- Description for the changelog
Added setting page button widget