-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: #222 UI Redesign - Mobile - Trusted Senders #227
base: ui_redesign
Are you sure you want to change the base?
Conversation
@Becca-Saka could you make it so this screen is shown when someone presses Trusted Senders on the menu that appears on the right? |
Sure, I'll do that now |
Does this work or should it be a full page? @tinashe404 |
@Becca-Saka For now that will work. Make sure the code is already in the PR so that we don't need to add code in order to review. |
@tinashe404 pushed my changes |
@Becca-Saka The screens look great. Do you plan on adding in the functionality that is currently implemented on the existing trusted senders screens. You should be able to just copy it over so that
This is all that is required for this issue and all the above functionality just needs to be copied over. |
Hey, @tinashe404 Sorry for the late response. I made the changes
|
@Becca-Saka This is awesome! @sachins-geekyants and @nitesh2599 please could you do a code review? |
@tinashe404 The code looks fine to me. But, there are some conflicts. |
@Becca-Saka Could you please resolve the conflicts in the above mentioned files? |
@nitesh2599 Resolved the conflicts |
- What I did
Created a new UI design for the trusted senders screen and a remove trusted sender dialog which closes #222
- How I did it
I created a new screen for the trusted senders screen inside the trusted contacts folder
- How to verify it
add the code to the welcome screen and you should be able to click the button to view the new screen
- Description for the changelog
Added trusted sender screen and dialog