Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #222 UI Redesign - Mobile - Trusted Senders #227

Open
wants to merge 8 commits into
base: ui_redesign
Choose a base branch
from

Conversation

Becca-Saka
Copy link

- What I did
Created a new UI design for the trusted senders screen and a remove trusted sender dialog which closes #222

- How I did it
I created a new screen for the trusted senders screen inside the trusted contacts folder

- How to verify it
add the code to the welcome screen and you should be able to click the button to view the new screen

 CustomOutlinedButton(
     buttonText: 'Trusted Senders',
      onPressed: () {
              showModalBottomSheet(
                  context: context,
                  elevation: 10,
                  isScrollControlled: true,
                  //color with gradient
                  barrierColor: Colors.white
                      .withOpacity(0.25)
                      .withOpacity(0.6),
                  shape: RoundedRectangleBorder(
                      borderRadius: BorderRadius.only(
                          topLeft:
                              Radius.circular(20.toWidth),
                          topRight:
                              Radius.circular(20.toWidth))),
                  builder: (context) => BackdropFilter(
                      filter: ImageFilter.blur(
                        sigmaY: -2,
                      ),
                      child: TrustedSenders()));
               },
    ),

- Description for the changelog
Added trusted sender screen and dialog

Simulator Screen Shot - iPhone 11 Pro Max - 2022-10-03 at 15 57 57
Simulator Screen Shot - iPhone 11 Pro Max - 2022-10-03 at 15 57 54

@Becca-Saka Becca-Saka changed the title UI Redesign - Mobile - Trusted Senders fixes #222 UI Redesign - Mobile - Trusted Senders Oct 3, 2022
@Becca-Saka Becca-Saka changed the title UI Redesign - Mobile - Trusted Senders fix: #222 UI Redesign - Mobile - Trusted Senders Oct 3, 2022
@tinashe404
Copy link
Member

@Becca-Saka could you make it so this screen is shown when someone presses Trusted Senders on the menu that appears on the right?

@Becca-Saka
Copy link
Author

Sure, I'll do that now

@Becca-Saka
Copy link
Author

Simulator Screen Shot - iPhone SE (3rd generation) - 2022-10-12 at 11 38 14

Does this work or should it be a full page? @tinashe404

@tinashe404
Copy link
Member

@Becca-Saka For now that will work. Make sure the code is already in the PR so that we don't need to add code in order to review.

@Becca-Saka
Copy link
Author

@tinashe404 pushed my changes

@tinashe404
Copy link
Member

@Becca-Saka The screens look great. Do you plan on adding in the functionality that is currently implemented on the existing trusted senders screens.

You should be able to just copy it over so that

  • when you click Add atsign it shows the contacts screen... where people can add the trusted senders to the list
  • It displays actual contacts from the trusted senders list and not hard coded ones (Since most of them dont have pictures you can display a default image for all of them)
  • It shows the search filter as someone types in the search
  • clicking on a contact gives the option to remove them from the trusted senders list and clicking confirm removes them

This is all that is required for this issue and all the above functionality just needs to be copied over.

@Becca-Saka
Copy link
Author

Hey, @tinashe404 Sorry for the late response. I made the changes

  1. Image functionality: I used the existing way to load the user's image, If it's empty it shows a placeholder

Simulator Screen Shot - iPhone 14 - 2022-10-30 at 09 44 08
Simulator Screen Shot - iPhone 14 - 2022-10-30 at 09 43 54

  1. It's possible for the nickname/name to be null so I am only showing the at sign in that situation

Simulator Screen Shot - iPhone 14 - 2022-10-30 at 09 42 34
Simulator Screen Shot - iPhone 14 - 2022-10-30 at 09 39 25

  1. Search function
    Simulator Screen Shot - iPhone 14 - 2022-10-30 at 10 03 51
    Simulator Screen Shot - iPhone 14 - 2022-10-30 at 10 03 44

  2. removing trusted contacts

Simulator Screen Shot - iPhone 14 - 2022-10-30 at 10 12 27
Simulator Screen Shot - iPhone 14 - 2022-10-30 at 10 12 22

@tinashe404
Copy link
Member

@Becca-Saka This is awesome! @sachins-geekyants and @nitesh2599 please could you do a code review?

@nitesh2599
Copy link
Contributor

nitesh2599 commented Nov 2, 2022

@tinashe404 The code looks fine to me. But, there are some conflicts.

@nitesh2599
Copy link
Contributor

@Becca-Saka Could you please resolve the conflicts in the above mentioned files?

@Becca-Saka
Copy link
Author

@nitesh2599 Resolved the conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants