Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #221 UI Redesign - Mobile - block atSign #237

Open
wants to merge 7 commits into
base: ui_redesign
Choose a base branch
from

Conversation

tanmoy27112000
Copy link

closes #221

- What I did
I created the bottom sheet to show all the blocked atSign

- How I did it
I created separate customisable widget and separate function for the bottom sheet

- How to verify it
on welcome screen click on the welcome text to open the bottom sheet

- Description for the changelog
Added blocked at Sign bottom sheet

@tanmoy27112000 tanmoy27112000 changed the title UI Redesign - Mobile - Blocked atSigns #221 fix: #221 UI Redesign - Mobile - block atSign Oct 7, 2022
@tanmoy27112000
Copy link
Author

@ksanty please review this PR. Thanks!!

@tinashe404
Copy link
Member

Hi, just tried to check this and when I click on the welcome screen it produces this error message.

Screenshot 2022-10-12 at 1 15 33 PM

@tanmoy27112000
Copy link
Author

added the init function for sizeconfig now its working fine @tinashe404

@tinashe404
Copy link
Member

@tanmoy27112000 The error message is still appearing.

@tanmoy27112000
Copy link
Author

tanmoy27112000 commented Oct 14, 2022

Sorry fixed In wrong branch now working fine and verified. @tinashe404
Screenshot_1665776247

@tinashe404
Copy link
Member

@tanmoy27112000 I've had a look. The UI looks good but there is no functionality implemented in it yet. Is this something you plan on doing?

The ideal PR would be one where

  • this screen/widget appears when you click on Blocked atSigns in the right hand menu
  • the close button closes this widget
  • the refresh button refreshes what is displayed on this widget
  • the widget displays the list of blocked atSigns (which is displayed on the current blocked atSigns screen, so you should just copy the functionality over)
  • clicking unblock, removes the atSign from the blocked list (as is done on the current blocked atSigns screen, so you should just copy the functionality over)
  • If you can't figure out how to search and sort we can leave this for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants