-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: #221 UI Redesign - Mobile - block atSign #237
Open
tanmoy27112000
wants to merge
7
commits into
atsign-foundation:ui_redesign
Choose a base branch
from
tanmoy27112000:ui/blockedAtSign
base: ui_redesign
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix: #221 UI Redesign - Mobile - block atSign #237
tanmoy27112000
wants to merge
7
commits into
atsign-foundation:ui_redesign
from
tanmoy27112000:ui/blockedAtSign
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanmoy27112000
changed the title
UI Redesign - Mobile - Blocked atSigns #221
fix: #221 UI Redesign - Mobile - block atSign
Oct 7, 2022
@ksanty please review this PR. Thanks!! |
added the init function for sizeconfig now its working fine @tinashe404 |
@tanmoy27112000 The error message is still appearing. |
Sorry fixed In wrong branch now working fine and verified. @tinashe404 |
@tanmoy27112000 I've had a look. The UI looks good but there is no functionality implemented in it yet. Is this something you plan on doing? The ideal PR would be one where
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #221
- What I did
I created the bottom sheet to show all the blocked atSign
- How I did it
I created separate customisable widget and separate function for the bottom sheet
- How to verify it
on welcome screen click on the welcome text to open the bottom sheet
- Description for the changelog
Added blocked at Sign bottom sheet