fix: Only allow single instance of NoPorts Desktop on Windows #1713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XavierChanth
commented
Jan 31, 2025
Comment on lines
+18
to
+24
| HWND hwnd = ::FindWindow(kWindowClassName, kWindowName); | ||
| if (hwnd != NULL) { | ||
| ::ShowWindow(hwnd, SW_NORMAL); | ||
| ::SetForegroundWindow(hwnd); | ||
| return EXIT_FAILURE; | ||
| } | ||
|
|
There was a problem hiding this comment.
If we find a window matching the default Flutter window class name && Titled "NoPorts Desktop" open that instead.
XavierChanth
commented
Jan 31, 2025
Comment on lines
-19
to
-20
| constexpr const wchar_t kWindowClassName[] = L"FLUTTER_RUNNER_WIN32_WINDOW"; | ||
|
|
There was a problem hiding this comment.
moved this to its .h file so we have access to it in main.cpp too.
|
I rebased 03d23e4 back onto trunk since it was based on a wildly divergent branch, then I retested. |
Correction, I am retesting... VSCode cached commits... so they appeared in the build despite the rebase. |
|
Okay, ready for review, tested with a git history that matches that of this PR. |
Zambrella
approved these changes
Jan 31, 2025
cconstab
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
The existing behavior:
Desired behavior (that this PR provides):
Retained behavior:
- How I did it
- How to verify it
- Description for the changelog
fix: Only allow single instance of NoPorts Desktop on Windows