This repository has been archived by the owner on Sep 1, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4
Message size/us133166/add message size parameter #78
Merged
kaylarizi
merged 9 commits into
main
from
messageSize/US133166/add_message_size_parameter
Jan 31, 2024
Merged
Message size/us133166/add message size parameter #78
kaylarizi
merged 9 commits into
main
from
messageSize/US133166/add_message_size_parameter
Jan 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jan 23, 2024
mikekcs
reviewed
Jan 23, 2024
…/US133166/add_message_size_parameter
…/US133166/add_message_size_parameter
mikekcs
reviewed
Jan 31, 2024
export class MessageGenerator { | ||
static generate(sizeInBytes: number) { | ||
// Generate the string by repeating the character 'a' | ||
return 'a'.repeat(sizeInBytes); } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can be nicer than 'aaaaaaaaaaaaaa' but not required
message = ''.join(random.choices(string.ascii_uppercase +
string.digits, k=N))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving it like this because there is no simple lib in nest.js that does this.
mikekcs
approved these changes
Jan 31, 2024
mikekcs
approved these changes
Jan 31, 2024
kaylarizi
deleted the
messageSize/US133166/add_message_size_parameter
branch
February 18, 2024 20:18
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add message size parameter to the analyze request, generated message accordingly and send to nginx.