Use X11/XWayland by default

[radioactiveman]

More and more distributions use Wayland by default now. Which brings new issues for Audacious, especially with the Winamp interface. Use X11/XWayland by default for now to avoid them.

See also:

• https://github.com/orgs/audacious-media-player/discussions/105
• https://github.com/orgs/audacious-media-player/discussions/1392
• https://github.com/orgs/audacious-media-player/discussions/1394

@madpilot78: Can you please verify that the x11 GDK backend and xcb Qt platform can be used on FreeBSD? I'm not sure yet if we should apply this for Linux only.

@jlindgren90: Is this implemented properly? I have tested it successfully with a Ubuntu 24.04 VM.

[jlindgren90]

LGTM

[madpilot78]

Hi,

Thanks for your work on audacious! Really appreciated!

I've tested your patch and compiled the latest beta with it included on FreeBSD. It works fine on my machine, with Xorg.

I'm unable to test with wayland since I don't have it configured. FreeBSD does support Wayland and people using it report it working fine. The reason I have not migrated is that I use XFCE as a desktop and it only has partial experimental support for Wayland at present (they are working on it though).

As far as I can see it should be fine as is, but if you need me to looks for specific things please ask.

[radioactiveman]

Thanks for the feedback. 👍

I found a more portable check for GTK. This should apply to all GTK 3 versions and systems where the Wayland and X11 backend is enabled.

#if defined(GDK_WINDOWING_WAYLAND) && defined(GDK_WINDOWING_X11)

instead of

#if defined(USE_GTK3) && defined(G_OS_UNIX) && !defined(__APPLE__)