Fix segfaults on timeout and invalid audio unit index #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andreas Pape <[email protected]>
Signed-off-by: Andreas Pape <[email protected]>
|
Thanks @aditpape . Changes look good to me! Are you able to sign the Contributor License Agreement on this pull request page of GitHub? That way there can never be any future copyright issues for anyone. |
|
Requested permission to sign the CLA from my employer. Hope I get a (positive) decision soon... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix segfaults on commands
a) show connections -> on timeout of GET_RX_STATE_COMMAND
b) get sampling_rate AUDIO_UNIT 3 -> on non existing index