correctly detects java versions above java 8 #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
felt bad about renaming the method and realised why.... subconscious was worried about breaking somebody else's code unexpectedly since it's a public method. Have instead deprecated it so both |
|
@janithb it would be great to get this merged.... happy to make changes if you don't want to merge as is |
yuyuchen09
pushed a commit
to yuyuchen09/audit4j-core
that referenced
this pull request
Mar 15, 2021
- bumped version to 2.6.2-ghx
|
Thank you for the merge! Are you going to merge other PRs, and do a public release? |
|
HI @janithb I need may application to be upgraded to java 11. But because of this issue, im unable to do this. Can you please let me know when will it be released? or any other alternative solution for this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a possible solution to #85
The java version checker called for the system property directly which made it hard to test so I've pulled that behaviour separate to the
EnvUtilsthat contained it and inject the system propertyThis let me write parameterised tests to check a range of java versions.
I spotted that
EnvUtil.getJavaVersionwas (I'm assuming) typoed asEnvUtil.getJavaersionso fixed that too.