Updated translations to match Intl.RelativeTime #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zewa666
reviewed
Sep 8, 2020
| year_in: '__count__ 年後', | ||
| year_in_plural: '__count__ 年後' | ||
| }, | ||
| 'zh-TW': { |
There was a problem hiding this comment.
seems like something got messed up here as this locale now seems to be part of another. I'll fix this along with the merge but perhaps we should check that in the other PR as well @josundt
There was a problem hiding this comment.
Oops... Human mistake, the zh-TW translation was copied from old translation to the generated since zh-TW is not included with the node full-icu. I will fix this in the other PR.
I guess this proves the importance of full automation when generating the translations 😁 (#320).
|
Thanks again for the contribution @josundt, will ping @EisenbergEffect for the patch release |
|
Thanks a lot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating translations to exactly match Intl.RelativeTime, ref #320