feat: add option for app-with-router #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@3cp , checks are failing, don't know why. Please check. |
3cp
requested changes
Mar 28, 2020
|
Sometimes github actions fails with strange network error. I can rerun it. But you will push soon, so it will check again anyway. |
all passed now. |
|
Thx. I will do some manual test before merge. After that, I will fill up the missing unit tests and e2e tests setup for this new skeleton. Will be merged in one or two days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@3cp ,
feat: app-with-router
continuation of #12
related to #5