fix(parseQueryString): do not remove '+' from query #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
davismj
requested changes
May 7, 2019
| @@ -226,7 +226,7 @@ export function parseQueryString(queryString: string): Object { | |||
| query = query.substr(1); | |||
| } | |||
|
|
|||
| let pairs = query.replace(/\+/g, ' ').split('&'); | |||
| let pairs = query.split('&'); | |||
There was a problem hiding this comment.
This wouldn't yield the desired behavior. + literals are spaces.
| @@ -272,5 +272,7 @@ describe('query strings', () => { | |||
| expect(parse('a[b][c][d]=e')).toEqual({a: {b: {c: {d: 'e'}}}}); | |||
| expect(parse('a[b][]=c&a[b][]=d&a[b][2][]=f&a[b][2][]=g')).toEqual({a: {b: ['c','d', ['f', 'g']]}}); | |||
| expect(parse('a[0]=b')).toEqual({a: ['b']}); | |||
|
|
|||
| expect(parse('a=b+c')).toEqual({a: 'b+c'}); | |||
There was a problem hiding this comment.
expect(parse('a=b+c')).toEqual({a: 'b c'});
expect(parse('a=b%2Bc')).toEqual({a: 'b+c'});
I would pull if these tests pass. Fair?
There was a problem hiding this comment.
The first line is exactly what I was trying to fix. If I pass %2B in a parameter it gets decoded in aurelia-browser-history and arrives as a '+', which is then replaced
There was a problem hiding this comment.
I'm happy to close the PR if aurelia-browser-history gets fixed. As of now, this is a pretty serious bug which prevents using Asp.net Identity completely
|
Closing as not working as the standard |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #30