Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete Aurora CLI Engine methods #2

Merged
merged 22 commits into from
Dec 23, 2022
Merged

Conversation

hskang9
Copy link
Contributor

@hskang9 hskang9 commented Oct 24, 2022

@hskang9 hskang9 marked this pull request as draft October 24, 2022 12:48
@hskang9 hskang9 marked this pull request as ready for review October 25, 2022 11:48
Cargo.toml Outdated Show resolved Hide resolved
src/cli/borsh_io.rs Outdated Show resolved Hide resolved
src/cli/json.rs Outdated Show resolved Hide resolved
src/cli/near.rs Outdated Show resolved Hide resolved
src/cli/near.rs Outdated Show resolved Hide resolved
src/cli/near.rs Outdated Show resolved Hide resolved
src/cli/near.rs Outdated Show resolved Hide resolved
src/cli/near.rs Outdated Show resolved Hide resolved
src/cli/near.rs Outdated Show resolved Hide resolved
src/cli/near.rs Outdated Show resolved Hide resolved
add getter method to aurora-engine

update .gitignore

remove .DS_Store

add rjson type serialization

add setter functions

remove deposit as bridge only should be allowed to use it

update README

update get_account_counter

update get_account_counter

update get_engine_bridge_prover
@hskang9 hskang9 requested a review from birchmd November 15, 2022 12:53
Copy link
Member

@birchmd birchmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few remaining nits, but looks good overall now!

Cargo.toml Outdated Show resolved Hide resolved
src/cli/mod.rs Show resolved Hide resolved
src/cli/near.rs Outdated Show resolved Hide resolved
src/cli/near.rs Outdated Show resolved Hide resolved
src/cli/near.rs Show resolved Hide resolved
src/cli/near.rs Outdated Show resolved Hide resolved
src/cli/near.rs Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved

- 📦 Install `aurora-cli-rs` and start interacting with it:
*`cargo install aurora-cli-rs`*
- 🔍 Check out what each command is for in the official Aurora [docs](https://doc.aurora.dev/tools/aurora-cli)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noting dependency on aurora-is-near/doc.aurora.dev#78
These PRs should be merged together so that the link here is not broken.

src/cli/near.rs Outdated Show resolved Hide resolved
@hskang9 hskang9 requested review from aleksuss and removed request for aleksuss November 25, 2022 11:24
@hskang9 hskang9 requested a review from birchmd November 25, 2022 11:24
src/cli/mod.rs Show resolved Hide resolved
@aleksuss aleksuss merged commit 4ab050f into aurora-is-near:main Dec 23, 2022
aleksuss added a commit that referenced this pull request Jul 2, 2023
aleksuss added a commit that referenced this pull request Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants