Build heat conduction module into docker image #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Obviously pinning is the ideal, as each build of the image will use the same versions of packages, however, when Ubuntu patches a package it removes the old version. This means the build will fail as the old version of the package is no longer available. As the patches are only minor bug and security fixes, in our case I think it's reasonable to unpin.
The tests now make use of MOOSE's heat conduction module. Build it into the container to avoid building it in the CI.
This avoids us having to install them within the CI.
These packages are now installed within the CI's Docker image.
For some reason this crashes the build. I thought it was just my laptop running out of memory, but it crashes when I build the container on GitHub too.
hsaunders1904
deleted the
hsaunders1904/24_build_heat_conduction_module_into_docker_image
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the Dockerfile for the CI such that MOOSE's heat conduction module is built within it. This saves us building it in the CI every time.
We now deploy the docker image to, and pull from, UKAEA's Quay account (using a robot account's credentials), rather than my personal one.
The new docker image was built and pushed in this action using revision dcc37f4.
There's a minor refactor converting a
FoamProblemmember function to a free function in an anonymous workspace.Related Issue
Resolves #24
Resolves #15
Checklist