Make updates for compatibility with latest MOOSE version #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These stopped working after a MOOSE update, due to change made to the RunCommand test type. RunApp is better here anyway, as we can also run tests on debug builds, where before we only ever ran these tests using an 'opt' build.
A recent MOOSE update meant that the way we were using the 'RunCommand' test type stopped working. It seems like the first argument in the command string is now taken as the executable, and all subsequent parts of the string are passed as arguments to that executable. We were therefore getting errors when chaining commands together with '&&'. We can work around this by prefixing our one-line scripts with 'bash -c'.
The 'heat conduction' module was renamed 'heat transfer' in a recent version of MOOSE.
The signature of SubProblem::converged was changed in a recent version of MOOSE.
This silences a warning we get when running tests, and prevents the legacy behaviour where MOOSE executes an unnecessary residual check.
Remove the debug builds of libMesh to bring down the size of the Docker image.
|
New version of Docker image deployed in https://github.com/aurora-multiphysics/hippo/actions/runs/12234449168 and used in latest CI run. |
hsaunders1904
deleted the
hsaunders1904/32_make_updates_for_compatibility_with_latest_moose_version
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To use Hippo with the latest version of MOOSE we had to:
bool FoamProblem::converged()to the new form required by MOOSEbool FoamProblem::converged(const unsigned int).RunCommand, as upstream changes meant that the given command was no longer passed directly to the shell. It seems that the given string's first argument is taken as the executable and all subsequent arguments are passed to it, rather than the string being treated as a shell command. The fix here was to prefix all the command strings withbash.moose-devimage, which runs Rocky Linux rather than Ubuntu.Related Issue
Resolves #32
Checklist