Skip to content
This repository has been archived by the owner on May 1, 2019. It is now read-only.

parseHash(): "Cannot read property 'length' of undefined" if only access_token is returned #130

Open
dinvlad opened this issue Mar 3, 2017 · 2 comments

Comments

@dinvlad
Copy link

dinvlad commented Mar 3, 2017

Hi all,

When I set the audience in authParams for an API, Passwordless Lock works correctly by returning the hash with a full JWT access_token. This now takes place of the previously opaque access_token and a JWT id_token.

However, when I use parseHash() to parse the response, it reports Cannot read property 'length' of undefined because it's apparently still trying to parse id_token (which is now absent).

This could be related to auth0/lock#530. Would it be possible to patch Passwordless Lock to fix this error? Otherwise, we have to decodeURIComponent directly for the time being (I'm using socialOrEmailcode so I have to parse hash manually instead of returning them to a callback). EDIT: we can also include auth0.min.js and use parseHash() from there (though that's still extra work).

Thanks

@stephenhuh
Copy link

stephenhuh commented Dec 13, 2017

I'm having the same error but with socialOrSms, and soon (since I'm implementing both) probably socailOrEmailcode

@luisrudge
Copy link
Contributor

Can you send a PR with this fix?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants