Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 2546 - TypeError: Super expression must either be null or a function #2578

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Hworden
Copy link

@Hworden Hworden commented Aug 23, 2024

Changes

This moves the events package from a devDependency to a dependency. This ensures that when a consumer is installing the package that the events package will be installed. The events package makes available the EventsEmitter class which is typically available in node environments (not browser). It's used here in this repo.

This is the cause of the issue referenced here
#2546

Below is an image of the vite warning output explaining the same and below is the identical error referenced in the issue.
image

References

Aims to fix this #2546. By stepping through the debugger you can see that the referenced symbol is the missing EventsEmitter class.

Testing

  • This change adds unit test coverage
  • This change adds integration test coverage
  • This change has been tested on the latest version of the platform/language

Checklist

…sumer package installs, events is installed as well. The EventEmitter api is a node api and this package makes it for the browser.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant