-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT: Federated connections #1879
base: v4-backup
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Authentication server metadata discovery is moved to a seperate stateful class since it is also used in FC exchange method.
- nullish coalescing operator is used in favour of logical OR
- getAudience() getter added
- Added class members for FederatedConnections classs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Authentication server metadata discovery is moved here, this maintains an in-memory cache of the metadata, something that was maintained in the auth-client
itself as a class member.
Since this is used in FC exchange function as well, de-coupled the implementation from auth client.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Simplified logic of various method by extracting repeated code.
- Added getFCAT method with check for existing FCAT and writeback to session store.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved encrypted cookie read and write logic to this storage layer.
This also abstracts the sessionstore methods.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Performs FC exchange.
Only contains code releavant to exchange.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deals with FCAT serialization/deserialization processes.
Contains low-level logic for how FCATs are stored in the cookie store.
Maintains a 2-level map of provider:audience:FCAT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add logic to serialize/deserialize FCATs along with session data to cookie store.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added federatedConnectiontMap
prop.
WIP
Please see comments below