Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove IGA trigger from e2e test [DXEX-4601] #1048

Merged
merged 2 commits into from
Nov 6, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/management/actions.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@

actions.getAll().catch((err) => {
expect(err).toBeDefined();
done();

Check warning on line 105 in test/management/actions.test.ts

View workflow job for this annotation

GitHub Actions / Build and Test (18.17)

Avoid calling back inside of a promise

Check warning on line 105 in test/management/actions.test.ts

View workflow job for this annotation

GitHub Actions / Build and Test (20.3)

Avoid calling back inside of a promise
});
});

Expand Down Expand Up @@ -150,14 +150,14 @@
data[0].all_changes_deployed
);

done();

Check warning on line 153 in test/management/actions.test.ts

View workflow job for this annotation

GitHub Actions / Build and Test (18.17)

Avoid calling back inside of a promise

Check warning on line 153 in test/management/actions.test.ts

View workflow job for this annotation

GitHub Actions / Build and Test (20.3)

Avoid calling back inside of a promise
});
});

it('should perform a GET request', (done) => {
actions.getAll().then(() => {
expect(request.isDone()).toBe(true);
done();

Check warning on line 160 in test/management/actions.test.ts

View workflow job for this annotation

GitHub Actions / Build and Test (18.17)

Avoid calling back inside of a promise

Check warning on line 160 in test/management/actions.test.ts

View workflow job for this annotation

GitHub Actions / Build and Test (20.3)

Avoid calling back inside of a promise
});
});

Expand All @@ -171,7 +171,7 @@

actions.getAll().then(() => {
expect(request.isDone()).toBe(true);
done();

Check warning on line 174 in test/management/actions.test.ts

View workflow job for this annotation

GitHub Actions / Build and Test (18.17)

Avoid calling back inside of a promise

Check warning on line 174 in test/management/actions.test.ts

View workflow job for this annotation

GitHub Actions / Build and Test (20.3)

Avoid calling back inside of a promise
});
});

Expand All @@ -187,7 +187,7 @@
actions.getAll(params).then(() => {
expect(request.isDone()).toBe(true);

done();

Check warning on line 190 in test/management/actions.test.ts

View workflow job for this annotation

GitHub Actions / Build and Test (18.17)

Avoid calling back inside of a promise

Check warning on line 190 in test/management/actions.test.ts

View workflow job for this annotation

GitHub Actions / Build and Test (20.3)

Avoid calling back inside of a promise
});
});
});
Expand Down Expand Up @@ -227,7 +227,7 @@
actions.get({ id: data.id as string }).then(() => {
expect(request.isDone()).toBe(true);

done();

Check warning on line 230 in test/management/actions.test.ts

View workflow job for this annotation

GitHub Actions / Build and Test (18.17)

Avoid calling back inside of a promise

Check warning on line 230 in test/management/actions.test.ts

View workflow job for this annotation

GitHub Actions / Build and Test (20.3)

Avoid calling back inside of a promise
});
});

Expand All @@ -239,7 +239,7 @@
actions.get({ id: data.id as string }).catch((err) => {
expect(err).toBeDefined();

done();

Check warning on line 242 in test/management/actions.test.ts

View workflow job for this annotation

GitHub Actions / Build and Test (18.17)

Avoid calling back inside of a promise

Check warning on line 242 in test/management/actions.test.ts

View workflow job for this annotation

GitHub Actions / Build and Test (20.3)

Avoid calling back inside of a promise
});
});

Expand Down Expand Up @@ -271,7 +271,7 @@
expect(credentials.data.integration?.id).toBe(data.integration?.id);
expect(credentials.data.all_changes_deployed).toBe(data.all_changes_deployed);

done();

Check warning on line 274 in test/management/actions.test.ts

View workflow job for this annotation

GitHub Actions / Build and Test (18.17)

Avoid calling back inside of a promise

Check warning on line 274 in test/management/actions.test.ts

View workflow job for this annotation

GitHub Actions / Build and Test (20.3)

Avoid calling back inside of a promise
});
});

Expand Down Expand Up @@ -1110,7 +1110,7 @@
const data = [
{
id: '123',
trigger_id: 'iga-approval',
trigger_id: 'post-user-registration',
display_name: 'test',
action: {
id: 'action-id',
Expand Down
Loading