Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Interop Layer #1037

Closed
wants to merge 3 commits into from
Closed

fix: Interop Layer #1037

wants to merge 3 commits into from

Conversation

guabu
Copy link

@guabu guabu commented Jan 24, 2025

This PR removes the codegenConfig which was caused builds to fail when running under the new architecture. This is also inline with the reactwg recommendation:

If you have already added a Codegen spec to your library, but the library is not fully converted to TurboModules/Fabric, we recommend that you delete it before proceeding. You can add this back when you are ready to convert your library to natively use TurboModules/Fabric without the Interop Layer.

The changes have been tested with a sample app using the following React Native versions:

  • 0.77.0
  • 0.76
  • 0.70.15

A follow-up PR will contain a complete migration to Turbo Modules.

The release is versioned as 4.1.0-interop.0 and should be tagged as @interop.

@guabu guabu requested a review from a team as a code owner January 24, 2025 06:50
package.json Outdated Show resolved Hide resolved
@EddyVinck
Copy link

Hello, I don't see this published yet when trying to install

When can we expect it? I wanted to try it already

@poovamraj
Copy link
Contributor

@EddyVinck we are waiting for community feedback but this will be released early next week. You can test this using npm command

npm install "https://github.com/guabu/react-native-auth0.git#fix-interop" --save

@EddyVinck
Copy link

@EddyVinck we are waiting for community feedback but this will be released early next week. You can test this using npm command

npm install "https://github.com/guabu/react-native-auth0.git#fix-interop" --save

Thanks! I just tested it with a fresh Ignite project and it appears to build on my Android emulator using the new architecture.

@Manikandan-saminathan
Copy link

@poovamraj I tested on both the new and old arch and the build was successful.

@poovamraj poovamraj mentioned this pull request Jan 27, 2025
3 tasks
@pmathew92 pmathew92 mentioned this pull request Jan 27, 2025
@poovamraj poovamraj closed this Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants