-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Passkey Support #1099
Add Passkey Support #1099
Conversation
@chrisnellis Hello! Here's some steps to get this moving forward:
Hope that helps. |
@duedares-rvj , thanks for your guidance! I just finished signing my commits after I gave the |
@duedares-rvj , I think things are in a good place now for this to be reviewed :) Let me know what you think |
@kushalshit27, could you and your team please let me know what the review timeline would be for this? |
@chrisnellis Hello! I think this slipped down the stack but here's the next steps:
Please tag me and I'll try to respond asap! :) |
@duedares-rvj |
Hi @duedares-rvj and @chrisnellis, just wanted to check on this. In my org we're not allowed to deploy any feature without Terraform. So we're desperately waiting for this change 😄 Thanks for the work you put into this! |
@alfechner, I'm not affiliated with Okta. I'm just a nerd who had some free time to help :) I'm also waiting on @duedares-rvj for next steps |
@chrisnellis I tried to add some changes but I do not have write access to your repo. Minor change here: Post that, please run the below: This would delete old recordings of the tests and re-add the recordings. You'll see the below files deleted and re-added: Rest everything looks great in the PR! |
Hey, @duedares-rvj I have made the expected change to the flatten.go file. As far as the acceptance tests go, I need your help setting a set of credentials to run the tests with. In the If you could either email me valid credentials to use for this, help me run it and record, or direct me to use my own Auth0 tenant for this purpose, let me know and I'll comply. I also invited you to my repo if you want to make your own changes to my PR |
@chrisnellis That's alright. |
🔧 Changes
authenitcation_methods
block to connections (referencing Auth0's API documentation)paskey_options
block to connections (referencing Auth0's API documentation)📚 References
Attempting to fix #924
🔬 Testing
Ran acceptance tests, observed the recorded JSON API calls and ensured they match the API documentation
📝 Checklist