Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the libraries and make it compatible with Java8 #607

Closed
authorjapps opened this issue Nov 22, 2023 · 5 comments · Fixed by #641
Closed

Upgrade the libraries and make it compatible with Java8 #607

authorjapps opened this issue Nov 22, 2023 · 5 comments · Fixed by #641
Assignees

Comments

@authorjapps
Copy link
Owner

AC:
Upgrade the dependant libraries to their latest compatible version with Java8.

This seems like a pre-req or a good excersize before switching to Java17.


Some work already has been done by @baulea .

Hello @baulea , can you please put the ticket/issue details and PR details in the comments for everyone's visibility?

@authorjapps authorjapps added this to the JAVA17-AMERICA milestone Nov 22, 2023
@chaitanya1607
Copy link

Can I take this up

@baulea
Copy link
Contributor

baulea commented Nov 24, 2023

AC: Upgrade the dependant libraries to their latest compatible version with Java8.

This seems like a pre-req or a good excersize before switching to Java17.

Some work already has been done by @baulea .

Hello @baulea , can you please put the ticket/issue details and PR details in the comments for everyone's visibility?

Yes, I will soon provide the PR, probably on Sunday.

@baulea baulea mentioned this issue Nov 24, 2023
13 tasks
@baulea
Copy link
Contributor

baulea commented Nov 24, 2023

Hi @authorjapps, I created the following pull request: #609

The PR includes the following:

  • consolidate maven plugins:

    • Move maven plugin versions and configuration to pluginManagement section in parent.pom.
    • Upgrade maven plugin versions
    • Fix warnings during maven build regarding missing version for maven-compiler-plugin
  • upgrade dependencies in pom.xml:

    • upgrade org.jukito:jukito from 1.4.1 to 1.5
    • upgrade commons-io:commons-io:2.4 to 2.15.0
    • upgrade com.aventstack:extentreports:4.0.9 to 5.0.9
    • upgrade com.google.code.gson:gson:2.6.2 to 2.10.1
    • upgrade com.google.protobuf:protobuf-java:3.13.0 to 3.24.4
  • with upgrade com.aventstack:extentreports:4.0.9 to 5.0.9 replace ExtentHtmlReporter with ExtentSparkReporter in ExtentReportsFactory.java

  • change in core/pom.xml:

    • set test scope for org.jukito:jukito
    • remove unused dependency com.fasterxml.jackson.datatype:jackson-datatype-jdk8
    • remove direct dependency ch.qos.logback:logback-core, because it is a direct dependency from ch.qos.logback:logback-classic
    • add direct dependency org.apache.httpcomponents:httpmime:4.5.12
  • change in kafka-testing/pom.xml:

    • remove com.google.protobuf:protobuf-java-util
    • remove dependency for com.github.os72:protoc-jar

@baulea
Copy link
Contributor

baulea commented Dec 19, 2023

Hi @authorjapps, is there anything else I should do? Or are we just waiting for a reviewer to review the PR #609 ?

@baulea
Copy link
Contributor

baulea commented Feb 27, 2024

As suggested by @a1shadows in #609 I'll have a look at some more dependencies and try an upgrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants