-
-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade logback from 1.0.7 to 1.3.14 and slf4j to 2.0.12 #632
Conversation
Capturing the diff in logback logs from another CI build and this one: Older builds:
This build:
|
Hi @a1shadows, the log entries logback outputs while reading its configuration files changed with the new version of logback. But the additional entries are only of type "INFO"l. Some of them are about a new feature called SerializedModelConfigurator like "Could NOT find resource [logback.scmo]", (https://logback.qos.ch/manual/configuration.html). Other log entries from the application itself did not change. |
No, looks good to me. Just thought to capture the log diff for future reference. Looks good to merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
upgrade logback from 1.0.7 to 1.3.14
PR Branch
https://github.com/baulea/zerocode/tree/upgrade_logback
Motivation and Context
This also solves Bump logback-core from 1.0.7 to 1.2.9 #533 and Bump logback-classic from 1.0.7 to 1.2.0 #499
Checklist:
Unit tests added
Integration tests added
Test names are meaningful
Feature manually tested
Branch build passed
No 'package.*' in the imports
Relevant Wiki page updated with clear instruction for the end user
Http test added to
http-testing
module(if applicable) ?Kafka test added to
kafka-testing
module(if applicable) ?