Changed the definition from interface to class

[keerthikumarn]

@codeowners

PR Branch
#(#562)

since interfaces are primarily used for defining APIs and contracts. In this case, using a class with static final fields is a good alternative.

Checklist:

• Unit tests added

• Integration tests added

• Test names are meaningful

• Feature manually tested

• Branch build passed

• No 'package.*' in the imports

• Relevant Wiki page updated with clear instruction for the end user

  • Not applicable. This was only a refactor change, no functional or behaviour changes were introduced

• Http test added to http-testing module(if applicable) ?

  • Not applicable. The changes did not affect HTTP automation flow

• Kafka test added to kafka-testing module(if applicable) ?

  • Not applicable. The changes did not affect Kafka automation flow

[keerthikumarn]

can some please review this PR asap and provide any comments if something to be corrected???

[nirmalchandra]

can some please review this PR asap and provide any comments if something to be corrected???

CI build in-progress.
https://github.com/authorjapps/zerocode/pull/562/checks

Once done, we should be able to merge to master.

Just checking, how does this change help the end users i.e. a SDET or a DEV ?

[keerthikumarn]

This is just a small design change. There is no point in having an interface without defining any apis which in turn is the violation of interface definition.

…

On Fri, Jan 19, 2024 at 3:52 PM nirmalchandra ***@***.***> wrote: can some please review this PR asap and provide any comments if something to be corrected??? CI build in-progress. https://github.com/authorjapps/zerocode/pull/562/checks Once done, we should be able to merge to master. Just checking, how does this change help the end users i.e. a SDET or a DEV ? — Reply to this email directly, view it on GitHub <#562 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABJ2ZSE4TPFFYNVLHYEWBWLYPJCPFAVCNFSM6AAAAAAWIYTZWWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBQGEZTMMRQG4> . You are receiving this because you authored the thread.Message ID: ***@***.***>

-- *Thanks & Regards,* *Keerthi Kumar N*

[a1shadows]

This is just a small design change. There is no point in having an interface without defining any apis which in turn is the violation of interface definition.

I think it is a subjective opinion to not want to use interfaces for Constants. Do you have anything more concrete in mind for why you think interfaces shouldn't be used for Constants? I would argue the shorter syntax for declaring constants is actually a plus here