Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing marks broke with #8, specifically within the
handleMark
function.d1abb5c#diff-1cdd5cad54822249d22829cef95393e37707fcdb58e789e1a217c9f847ff9d9aL114-L120
This PR reimplements removing marks by checking if mark value is null, which is the only way we know that a mark is deleted as the MarkPatch type is not that expressive (Peritext has separate AddMark and RemoveMark patches).
Slightly awkward with ProseMirror's API, as you can create a mark passing in null (defaultAttrs is used to fill in missing attrs).
Fixes #12