-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storage adapter for MongoDB #386
Draft
kraenhansen
wants to merge
1
commit into
automerge:main
Choose a base branch
from
kraenhansen:storage-mongodb
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
Copyright (c) 2019-2023, Ink & Switch LLC | ||
|
||
Permission is hereby granted, free of charge, to any person obtaining a copy | ||
of this software and associated documentation files (the "Software"), to deal | ||
in the Software without restriction, including without limitation the rights | ||
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
copies of the Software, and to permit persons to whom the Software is | ||
furnished to do so, subject to the following conditions: | ||
|
||
The above copyright notice and this permission notice shall be included in all | ||
copies or substantial portions of the Software. | ||
|
||
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
SOFTWARE. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
{ | ||
"name": "@automerge/automerge-repo-storage-mongodb", | ||
"version": "2.0.0-alpha.11", | ||
"description": "MongoDB storage adapter for Automerge Repo", | ||
"repository": "https://github.com/automerge/automerge-repo/tree/master/packages/automerge-repo-storage-mongodb", | ||
"author": "Kræn Hansen <[email protected]>", | ||
"license": "MIT", | ||
"type": "module", | ||
"main": "dist/index.js", | ||
"scripts": { | ||
"build": "tsc", | ||
"watch": "npm-watch build", | ||
"test": "vitest" | ||
}, | ||
"dependencies": { | ||
"@automerge/automerge-repo": "workspace:*", | ||
"mongodb": "^6.8.0" | ||
}, | ||
"watch": { | ||
"build": { | ||
"patterns": "./src/**/*", | ||
"extensions": [ | ||
".ts" | ||
] | ||
} | ||
}, | ||
"publishConfig": { | ||
"access": "public" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,159 @@ | ||
/** | ||
* @packageDocumentation | ||
* A `StorageAdapter` which stores data in MongoDB | ||
*/ | ||
|
||
import { | ||
Chunk, | ||
StorageAdapterInterface, | ||
type StorageKey, | ||
} from "@automerge/automerge-repo/slim" | ||
import { MongoClient, MongoClientOptions, Collection, BSON } from "mongodb" | ||
import assert from "node:assert" | ||
|
||
// function storageKeyToString(key: StorageKey) { | ||
// return key.join("/") | ||
// } | ||
|
||
/** | ||
* Assert that the argument passed is an array of strings | ||
* NOTE: This is necessary to enable passing this directly to the database | ||
*/ | ||
function assertStorageKey(value: unknown): asserts value is StorageKey { | ||
assert(Array.isArray(value), "Expected an array") | ||
for (const element of value) { | ||
assert(typeof element === "string", "Expected an array of strings") | ||
} | ||
} | ||
|
||
/** | ||
* Builds a query filter from a key prefix using "array index position" | ||
* See https://www.mongodb.com/docs/manual/tutorial/query-arrays/#query-for-an-element-by-the-array-index-position | ||
*/ | ||
function buildKeyPrefixFilter(keyPrefix: StorageKey) { | ||
return Object.fromEntries(keyPrefix.map((part, i) => { | ||
return [`key.${i}`, part] | ||
})) | ||
} | ||
|
||
type ChunkDocument = { key: StorageKey; data: BSON.Binary } | ||
|
||
type MongoDBStorageAdapterOptions = { | ||
dbName?: string | ||
collectionName?: string | ||
/** The strategy for storing and querying keys */ | ||
keyStorageStrategy?: "array" | "string" | ||
} | ||
|
||
export class MongoDBStorageAdapter implements StorageAdapterInterface { | ||
#client: MongoClient | ||
#dbName: string | ||
#collectionName: string | ||
#collection: Promise<Collection<ChunkDocument>> | undefined = undefined | ||
|
||
/** | ||
* @param url - The url of the MongoDB server. | ||
* @param options - Additional options to pass when instantiating the MongoDB client. | ||
*/ | ||
constructor( | ||
url: string, | ||
options?: MongoDBStorageAdapterOptions & MongoClientOptions | ||
) | ||
|
||
/** | ||
* @param client - The MongoDB client. | ||
* @param options - Additional options. | ||
*/ | ||
constructor(client: MongoClient, options?: MongoDBStorageAdapterOptions) | ||
|
||
/** | ||
* @param url - The url of the MongoDB server. | ||
* @param options - Additional options to pass when instantiating the MongoDB client. | ||
*/ | ||
constructor( | ||
urlOrClient: MongoClient | string, | ||
{ | ||
dbName = "automerge", | ||
collectionName = "chunks", | ||
keyStorageStrategy = "array", | ||
...clientOptions | ||
}: MongoDBStorageAdapterOptions & MongoClientOptions = {} | ||
) { | ||
this.#dbName = dbName | ||
this.#collectionName = collectionName | ||
if (typeof urlOrClient === "string") { | ||
this.#client = new MongoClient(urlOrClient, clientOptions) | ||
} else if (urlOrClient instanceof MongoClient) { | ||
this.#client = urlOrClient | ||
} else { | ||
throw new TypeError( | ||
"Expected first argument to be either a client or a url string" | ||
) | ||
} | ||
if (keyStorageStrategy === "string") { | ||
throw new Error("Using strings for key storage isn't implemented yet") | ||
} | ||
} | ||
|
||
async load(key: StorageKey): Promise<Uint8Array | undefined> { | ||
assertStorageKey(key) | ||
const collection = await this.collection | ||
const result = await collection.findOne({ key }) | ||
if (result) { | ||
return new Uint8Array(result.data.value()) | ||
} else { | ||
return undefined | ||
} | ||
} | ||
|
||
async save(key: StorageKey, data: Uint8Array): Promise<void> { | ||
assertStorageKey(key) | ||
const collection = await this.collection | ||
await collection.updateOne( | ||
{ key: key }, | ||
{ $set: { data: new BSON.Binary(data) } }, | ||
{ upsert: true } | ||
) | ||
} | ||
|
||
async remove(key: StorageKey): Promise<void> { | ||
assertStorageKey(key) | ||
const collection = await this.collection | ||
await collection.deleteOne({ key }) | ||
} | ||
|
||
async loadRange(keyPrefix: StorageKey): Promise<Chunk[]> { | ||
assertStorageKey(keyPrefix) | ||
const collection = await this.collection | ||
const query = buildKeyPrefixFilter(keyPrefix) | ||
const cursor = await collection.find(query) | ||
if (cursor) { | ||
const result: Chunk[] = [] | ||
for await (const { key, data } of cursor) { | ||
result.push({ key, data: new Uint8Array(data.value()) }) | ||
} | ||
return result | ||
} else { | ||
return [] | ||
} | ||
} | ||
|
||
async removeRange(keyPrefix: StorageKey): Promise<void> { | ||
assertStorageKey(keyPrefix) | ||
const collection = await this.collection | ||
const query = buildKeyPrefixFilter(keyPrefix) | ||
await collection.deleteMany(query) | ||
} | ||
|
||
private get collection(): Promise<Collection<ChunkDocument>> { | ||
// Lazily connects the client and constructs the db and collection | ||
if (!this.#collection) { | ||
this.#collection = this.#client | ||
.connect() | ||
.then(client => | ||
client.db(this.#dbName).collection(this.#collectionName) | ||
) | ||
} | ||
return this.#collection | ||
} | ||
} |
70 changes: 70 additions & 0 deletions
70
packages/automerge-repo-storage-mongodb/test/MongoDBStorageAdapter.test.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,70 @@ | ||
import cp from "node:child_process" | ||
import { beforeAll, describe } from "vitest" | ||
import { MongoClient } from "mongodb" | ||
import { runStorageAdapterTests } from "../../automerge-repo/src/helpers/tests/storage-adapter-tests" | ||
import { MongoDBStorageAdapter } from "../src" | ||
|
||
const MONGODB_URL = "mongodb://localhost:27017" | ||
const MONGODB_DB_NAME = "automerge-repo-test-db" | ||
const MONGODB_COLLECTION_NAME = "automerge-repo-storage" | ||
const MONGODB_DOCKER_CONTAINER_NAME = "automerge-repo-test-mongo" | ||
|
||
/** | ||
* @returns true if the docker cli is available | ||
*/ | ||
function hasDocker() { | ||
try { | ||
cp.execFileSync("docker", ["--version"], { encoding: "utf8" }) | ||
return true | ||
} catch { | ||
return false | ||
} | ||
} | ||
|
||
let client: MongoClient | ||
|
||
describe.skipIf(!hasDocker())("MongoDBStorageAdapter", () => { | ||
beforeAll(async () => { | ||
try { | ||
cp.execFileSync("docker", ["kill", MONGODB_DOCKER_CONTAINER_NAME]) | ||
} catch { | ||
// Will fail if no dockers are running | ||
} | ||
const mongoContainerId = cp | ||
.execFileSync( | ||
"docker", | ||
[ | ||
"run", | ||
"--rm", | ||
"--detach", | ||
"--publish", | ||
"27017:27017", | ||
"--name", | ||
MONGODB_DOCKER_CONTAINER_NAME, | ||
"mongo", | ||
], | ||
{ encoding: "utf8" } | ||
) | ||
.trim() | ||
|
||
client = new MongoClient(MONGODB_URL) | ||
await client.connect() | ||
|
||
return async () => { | ||
cp.execFileSync("docker", ["kill", mongoContainerId]) | ||
} | ||
}) | ||
// TODO: Check if docker is available and skip tests if not | ||
const setup = async () => { | ||
const adapter = new MongoDBStorageAdapter(MONGODB_URL, { | ||
dbName: MONGODB_DB_NAME, | ||
collectionName: MONGODB_COLLECTION_NAME, | ||
}) | ||
const teardown = async () => { | ||
await client.db(MONGODB_DB_NAME).dropCollection(MONGODB_COLLECTION_NAME) | ||
} | ||
return { adapter, teardown } | ||
} | ||
|
||
runStorageAdapterTests(setup) | ||
}) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
{ | ||
"compilerOptions": { | ||
"target": "ESNext", | ||
"module": "NodeNext", | ||
"moduleResolution": "Node16", | ||
"declaration": true, | ||
"declarationMap": true, | ||
"outDir": "./dist", | ||
"esModuleInterop": true, | ||
"forceConsistentCasingInFileNames": true, | ||
"strict": true, | ||
"skipLibCheck": true | ||
}, | ||
"include": ["src/**/*.ts"] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
{ | ||
"extends": ["../../typedoc.base.json"], | ||
"entryPoints": ["src/index.ts"], | ||
"readme": "none" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
import { defineConfig, mergeConfig } from "vitest/config" | ||
import rootConfig from "../../vitest.config" | ||
|
||
export default mergeConfig( | ||
rootConfig, | ||
defineConfig({ | ||
test: { | ||
environment: "node", | ||
}, | ||
}) | ||
) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Skipping tests if
docker
is not available on the machine.