-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CodeContent component #310
base: master
Are you sure you want to change the base?
Conversation
I would like to use file-code icon instead but it does not seem to load, I'm guessing version of font in the pushpin doesn't include it. Based on feeback I might attempt to address that or leave it as is. |
I love this! Nice work, @Gozala! |
@pvh how do we make progress here ? After reading the pushpin design notes I'm wondering if there is a room for intentionally less discoverable features e.g. "view source" had being super power of early web although it was out of sight for most users. Is there room for this kind of things in pushpin ? I have being thinking more about the fact that indeed existing Below are few ideas how we can allow switch from plain text to code. Derive syntax from the doc titleUnlike
Subtle controlsAt the moment text widget has no controls & no clutter is great. What if we had both ? I think iA Writer does a great job in accomplishing exactly that What if we added either status bar similar to it except with syntax mode selector similar to vscode. Alternatively we could surface that selector only in list mode & in fact we could do so only when hovered as well. Multiple content type registrationsAlternatively we could allow conflicting content type registrations, meaning code component could also register itself as handler of In fact it is also worth considering if just surfacing focused widget header in the top bar is a better than surfacing a board itself. |
Link to why we stopped using CodeMirror for posterity (as we talked about) https://github.com/inkandswitch/pushpin/pull/250 |
It mostly attempt to resurrect previously existing
TextContent
component but as a separate entity. Unlike previous version this one allows editing ofdoc.title
(which defaults tonote.md
) in list context, which is treating as filename from which syntax mode is derived & activated