Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Voltera V-One recipes and add code signature verification and versioning #78

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

homebysix
Copy link
Member

This PR updates the download method for Voltera V-One, and adds code signature verification and versioning to the process.

It also removes the URLDownloaderImproved processor, since it's no longer needed.

Verbose recipe run output:

% autopkg run -vvq 'Voltera/Voltera.download.recipe'
Processing Voltera/Voltera.download.recipe...
WARNING: Voltera/Voltera.download.recipe is missing trust info and FAIL_RECIPES_WITHOUT_TRUST_INFO is not set. Proceeding...
URLDownloader
{'Input': {'filename': 'Voltera.dmg',
           'url': 'https://voltera-styx.herokuapp.com/download/osx'}}
URLDownloader: No value supplied for prefetch_filename, setting default value of: False
URLDownloader: No value supplied for CHECK_FILESIZE_ONLY, setting default value of: False
URLDownloader: Downloaded ~/Library/AutoPkg/Cache/com.github.bnpl.autopkg.download.voltera/downloads/Voltera.dmg
{'Output': {'download_changed': True,
            'pathname': '~/Library/AutoPkg/Cache/com.github.bnpl.autopkg.download.voltera/downloads/Voltera.dmg',
            'url_downloader_summary_result': {'data': {'download_path': '~/Library/AutoPkg/Cache/com.github.bnpl.autopkg.download.voltera/downloads/Voltera.dmg'},
                                              'summary_text': 'The following '
                                                              'new items were '
                                                              'downloaded:'}}}
EndOfCheckPhase
{'Input': {}}
{'Output': {}}
CodeSignatureVerifier
{'Input': {'input_path': '~/Library/AutoPkg/Cache/com.github.bnpl.autopkg.download.voltera/downloads/Voltera.dmg/Voltera.app',
           'requirement': 'identifier "io.Voltera.voltera-styx" and anchor '
                          'apple generic and certificate '
                          '1[field.1.2.840.113635.100.6.2.6] /* exists */ and '
                          'certificate leaf[field.1.2.840.113635.100.6.1.13] '
                          '/* exists */ and certificate leaf[subject.OU] = '
                          '"7Y22ECF4T2"'}}
CodeSignatureVerifier: Mounted disk image ~/Library/AutoPkg/Cache/com.github.bnpl.autopkg.download.voltera/downloads/Voltera.dmg
CodeSignatureVerifier: Verifying code signature...
CodeSignatureVerifier: Deep verification enabled...
CodeSignatureVerifier: Strict verification not defined. Using codesign defaults...
CodeSignatureVerifier: /private/tmp/dmg.cG6fEh/Voltera.app: valid on disk
CodeSignatureVerifier: /private/tmp/dmg.cG6fEh/Voltera.app: satisfies its Designated Requirement
CodeSignatureVerifier: /private/tmp/dmg.cG6fEh/Voltera.app: explicit requirement satisfied
CodeSignatureVerifier: Signature is valid
{'Output': {}}
Versioner
{'Input': {'input_plist_path': '~/Library/AutoPkg/Cache/com.github.bnpl.autopkg.download.voltera/downloads/Voltera.dmg/Voltera.app/Contents/Info.plist',
           'plist_version_key': 'CFBundleShortVersionString'}}
Versioner: No value supplied for skip_single_root_dir, setting default value of: False
Versioner: Mounted disk image ~/Library/AutoPkg/Cache/com.github.bnpl.autopkg.download.voltera/downloads/Voltera.dmg
Versioner: Found version 3.10.7 in file ~/Library/AutoPkg/Cache/com.github.bnpl.autopkg.download.voltera/downloads/Voltera.dmg/Voltera.app/Contents/Info.plist
{'Output': {'version': '3.10.7'}}
Receipt written to ~/Library/AutoPkg/Cache/com.github.bnpl.autopkg.download.voltera/receipts/Voltera.download-receipt-20241225-120453.plist

The following new items were downloaded:
    Download Path
    -------------
    ~/Library/AutoPkg/Cache/com.github.bnpl.autopkg.download.voltera/downloads/Voltera.dmg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant