Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-commit update and associated changes #493

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

homebysix
Copy link
Member

This PR includes updates to the pre-commit config, including:

  • addition of AutoPkg-specific checks from my pre-commit-macadmin repo
  • MinimumVersion updates where needed in order to match processors used in the recipe
  • avoidance of NAME input variable if overriding its value would break a process (e.g. Copier or CodeSignatureVerifier)
  • ensuring EndOfCheckPhase is included after completion of a download process
  • ensuring pkg type recipes have a clear pkg output, e.g. PkgCopier or PkgCreator

Pre-commit exclusions have been made for several recipe families (like munkitools, OmniGroup, and AutoPkgGitMaster) that don't follow usual AutoPkg recipe type conventions.

The remaining failure will be solved by eventual removal of the deprecated AdobeReaderDC.pkg.recipe, and can be ignored.

% pre-commit run --all-files
Check AutoPkg Recipes....................................................Failed
- hook id: check-autopkg-recipes
- exit code: 1

AdobeReader/AdobeReaderDC.pkg.recipe: Recipe type pkg should contain one of these processors: ['AppPkgCreator', 'PkgCreator', 'PkgCopier'].

Forbid AutoPkg Overrides.................................................Passed
Forbid AutoPkg Trust Info................................................Passed
black....................................................................Passed
isort....................................................................Passed
seed isort known_third_party.............................................Passed
flake8...................................................................Passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant