Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Traceroute: Fix test to set time delay between probes. #104

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

basheerk
Copy link
Contributor

@basheerk basheerk commented May 8, 2017

Traceroute test to set time delay between probes failed,This is happening
because of the some drop in the probe packets.Small delay needs to added
between the two tests, then these drop of probe packets doesn't exist
and we get the expected the output in the stdout.
signed-off-by: Basheer K[email protected]

…ning

because of the some drop in the probe packets.Small delay needs to added
between the two tests, then these drop of probe packets doesn't exist
and we get the expected the output in the stdout.
Copy link
Member

@lmr lmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let us know if you can avoid adding a flat sleep here. Otherwise, I suppose this is fine.

@@ -88,6 +88,7 @@ function run_test()
# If this is the only test that passes for a system, then we can guess
# that there is some system in the probe path that expects some delay
# between probes
sleep 05
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, if you can add a waiting function for a certain system condition, that's always better than a flat sleep. Can you do that in this case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants