Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new image type:vhd/gce support in bootc image builder #5903

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chunfuwen
Copy link
Contributor

@chunfuwen chunfuwen commented Sep 19, 2024

Add new image type:vdh/gce support in bootc image builder
vhd/gce are newly introduced support disk image type, and is only supported on upstream

@chunfuwen chunfuwen force-pushed the add_vhd_bootc_image_build_case branch 2 times, most recently from 6b2cbc5 to 79710d7 Compare September 20, 2024 00:39
Comment on lines +841 to +1075
def convert_vhd_to_qcow2(params):
"""
Convert vhd disk format into qcow2

@param params: one dictionary wrapping various parameter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing return converted_image_path instruction here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@chunfuwen chunfuwen force-pushed the add_vhd_bootc_image_build_case branch 4 times, most recently from f7ab79c to 6e6d4dd Compare October 11, 2024 08:43
@chunfuwen chunfuwen changed the title Add new image type:vdh support in bootc image builder Add new image type:vdh/gce support in bootc image builder Oct 14, 2024
@chunfuwen chunfuwen changed the title Add new image type:vdh/gce support in bootc image builder Add new image type:vhd/gce support in bootc image builder Oct 14, 2024
@chunfuwen chunfuwen force-pushed the add_vhd_bootc_image_build_case branch 7 times, most recently from 29cc575 to d94fc4d Compare October 17, 2024 06:19
@chunfuwen chunfuwen force-pushed the add_vhd_bootc_image_build_case branch 12 times, most recently from 465b4a4 to dadcff3 Compare October 28, 2024 03:43
@chunfuwen chunfuwen force-pushed the add_vhd_bootc_image_build_case branch 2 times, most recently from 0461b90 to a41db25 Compare October 28, 2024 08:02
@chunfuwen chunfuwen force-pushed the add_vhd_bootc_image_build_case branch 8 times, most recently from 5836b56 to 217c9dc Compare November 12, 2024 03:03
@chunfuwen chunfuwen force-pushed the add_vhd_bootc_image_build_case branch 12 times, most recently from 3262d4a to 3a0c9c5 Compare November 15, 2024 15:30
@chunfuwen chunfuwen force-pushed the add_vhd_bootc_image_build_case branch 2 times, most recently from 32affb4 to 7f5c47b Compare November 25, 2024 01:08
@chunfuwen chunfuwen force-pushed the add_vhd_bootc_image_build_case branch 2 times, most recently from 4e182dd to edce1e8 Compare December 4, 2024 01:58
@chunfuwen chunfuwen force-pushed the add_vhd_bootc_image_build_case branch 2 times, most recently from cb4821b to 04be8e2 Compare December 11, 2024 07:27
@chunfuwen
Copy link
Contributor Author

@dzhengfy
@smitterl

Please help review this PR if you are free

vdh and gce are newly introduced support disk image type, and are only supported on upstream

Signed-off-by: chunfuwen <[email protected]>
@chunfuwen chunfuwen force-pushed the add_vhd_bootc_image_build_case branch from 04be8e2 to 04bb0df Compare December 16, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants