iface_bridge: make host interface configurable #6002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
chloerh
reviewed
Dec 2, 2024
| @@ -113,7 +113,8 @@ def check_net_functions(guest_ip, ping_count, ping_timeout, guest_session, host_ | |||
| filter_name = params.get("filter_name", "vdsm-no-mac-spoofing") | |||
| ping_count = params.get("ping_count", "5") | |||
| ping_timeout = float(params.get("ping_timeout", "10")) | |||
| iface_name = utils_net.get_net_if(state="UP")[0] | |||
| host_iface = params.get("host_iface") | |||
| iface_name = host_iface if host_iface else utils_net.get_net_if(state="UP")[0] | |||
There was a problem hiding this comment.
We have updated this part to use default gateway instead of the first up iface.
Would you like to take a look?
e0d65ec
On our test environment we must use not the first host interface. Make configurable but maintain default behavior if not configured. Signed-off-by: Sebastian Mitterle <[email protected]>
smitterl
force-pushed
the
iface_bridge
branch
from
9ee193e to
ab182c3
Compare
|
JOB ID : a641729606ce65926266f60a466d0558d0cc7d61 |
|
chloerh
approved these changes
Dec 12, 2024
TasmiyaNalatwad
pushed a commit
to TasmiyaNalatwad/tp-libvirt
that referenced
this pull request
Dec 12, 2024
…ice persistent across Multiple Reboot of VM 1. Changes made to support ppc64 arch and perform pci PT of network devices 2. Perform ping to other server ip and check the device network connectivity 3. Added test to check the device avilabity after multiple reboots of guest is done Merge pull request autotest#6002 from smitterl/iface_bridge iface_bridge: make host interface configurable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On our test environment we must use not the first host interface. Make configurable but maintain default behavior if not configured.