ethernet_interface: remove unsupported rom for s390x #6045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pending test results. My environment broke. |
smitterl
force-pushed
the
fix_mtu_interface
branch
from
7de6188 to
bd1b7fb
Compare
On s390x ROM tuning is not supported. Signed-off-by: Sebastian Mitterle <[email protected]>
smitterl
force-pushed
the
fix_mtu_interface
branch
from
bd1b7fb to
ffa8121
Compare
|
cliping
approved these changes
Dec 12, 2024
dzhengfy
reviewed
Dec 15, 2024
| @@ -40,10 +40,15 @@ | |||
| only smaller_mtu_multi_ifaces | |||
| extra_attrs = {'rom': {'enabled': 'no'}} | |||
| iface_attrs_2 = {'type_name': 'ethernet', 'target': {'dev': tap_name_2, 'managed': 'no'}, 'model': 'virtio', 'mtu': {'size': '${iface_mtu_2}'}, 'driver': {'driver_attr': {'name': 'vhost'}}, 'rom': {'enabled': 'no'}} | |||
| s390-virtio: | |||
There was a problem hiding this comment.
Could you help also add aarch64? ROM is also not supported on aarch64. Thanks.
| - macvtap: | ||
| vm_ping_outside = pass | ||
| vm_ping_host_public = fail | ||
| iface_attrs = {'target': {'dev': tap_name, 'managed': 'no'}, 'model': 'virtio', 'type_name': 'ethernet', **${mtu_attrs}, **${extra_attrs}} | ||
| s390-virtio: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On s390x ROM tuning is not supported.