Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate_with_virtual_devices: fix rng check method #6071

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

dzhengfy
Copy link
Contributor

@dzhengfy dzhengfy commented Dec 17, 2024

As there might be other built-in rng devices, we only need to check
if attached virtio rng is in rng_available.

Signed-off-by: Dan Zheng [email protected]

@dzhengfy dzhengfy force-pushed the fix_check_rng_migration branch from eb843da to e57f122 Compare December 17, 2024 07:20
@dzhengfy
Copy link
Contributor Author

Before the fix:
migrate.virtual_devices.rng.backend_builtin.precopy
Error in phase POST_MIGRATE_BACK: Device rng is not removed from vm

After the fix:
(1/1) type_specific.io-github-autotest-libvirt.migrate.virtual_devices.rng.backend_builtin.precopy: PASS (426.23 s)

libvirt-10.10.0

As there might be other built-in rng devices, we only need to check
if attached virtio rng is in rng_available.

Signed-off-by: Dan Zheng <[email protected]>
@dzhengfy dzhengfy force-pushed the fix_check_rng_migration branch from e57f122 to 4a29672 Compare December 17, 2024 07:53
@dzhengfy dzhengfy marked this pull request as ready for review December 19, 2024 05:56
@dzhengfy dzhengfy requested a review from Yingshun December 19, 2024 05:57
@Yingshun Yingshun merged commit caac457 into autotest:master Dec 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants